[PATCH] D109865: [NFC] `goto fail` has failed us in the past...

[David Blaikie via Phabricator via cfe-commits]

dblaikie added a comment.

(A possibly more robust option - so that this doesn't regress if someone adds a new "return true" codepath & forgets to release the cleanup (it looks like a pretty long function with several exits, etc) - would be to move the code into an "impl" function and have the original function call it, check the result, and do the cleanup once?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109865/new/

https://reviews.llvm.org/D109865