[PATCH] D110111: [WebAssembly] Add relaxed-simd feature

[Thomas Lively via Phabricator via cfe-commits]

tlively added a comment.

Nice! Thanks for writing this :D Do you know what happens when you actually try to compile some code with `-mrelaxed-simd`? I'm concerned that it will throw an error because the "relaxed-simd" target feature has not yet been defined in the backend (specifically in WebAssembly.td and in WebAssemblySubtarget.{h,cpp}).



================
Comment at: clang/lib/Basic/Targets/WebAssembly.cpp:105-107
+    case RelaxedSIMD:
+      Features["relaxed-simd"] = true;
+      LLVM_FALLTHROUGH;
----------------
I believe this should be above the `SIMD128` case so that when `RelaxedSIMD` is enabled it falls through and marks `SIMD128` as enabled as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110111/new/

https://reviews.llvm.org/D110111