[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith added a comment.

I'm a bit hesitant to trust lack of tests as proof that old FIXMEs can be resolved safely. Can you add some background information about why this was originally a specifier, and why it's safe to fix it now? (If you don't know, I suggest looking through git-blame to figure it out (unless @ahatanak already knows?).)



================
Comment at: clang/lib/AST/DeclPrinter.cpp:161-163
+    else if (const ArrayType *ATy = dyn_cast<ArrayType>(BaseType))
       BaseType = ATy->getElementType();
+    else if (const FunctionType *FTy = BaseType->getAs<FunctionType>())
----------------
Seems unrelated to this commit?


================
Comment at: clang/lib/AST/TypePrinter.cpp:313
   // Print qualifiers as appropriate.
-
   bool CanPrefixQualifiers = false;
----------------
Seems unrelated to this commit?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110068/new/

https://reviews.llvm.org/D110068