[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

Tue Sep 21 05:19:04 PDT 2021

aaron.ballman added inline comments.

================
Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1692-1694
+            const bool IsOneDimensionalArray =
+                !isa<ConstantArrayType>(CAT->getElementType());
+            if (IsOneDimensionalArray) {
----------------
ASDenysPetrov wrote:
> martong wrote:
> > aaron.ballman wrote:
> > > 
> > +1 for Aaron's suggestion, but then it would be really helpful to have an explanatory comment. E.g.:
> > ```
> > if (!isa<ConstantArrayType>(CAT->getElementType())) { // This is a one dimensional array.
> > ```
> I think that self-descriptive code is better than comments nearby. And it does not affect anything in terms of performance.
FWIW, I found the condensed form more readable (I don't have to wonder what's going to care about that variable later in the function with lots of nesting).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104285/new/

https://reviews.llvm.org/D104285