[clang] eccd477 - Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables

Sylvestre Ledru via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 21 01:45:14 PDT 2021


Author: Sylvestre Ledru
Date: 2021-09-21T10:44:08+02:00
New Revision: eccd477ce312c54e317876ca714c661325f3e318

URL: https://github.com/llvm/llvm-project/commit/eccd477ce312c54e317876ca714c661325f3e318
DIFF: https://github.com/llvm/llvm-project/commit/eccd477ce312c54e317876ca714c661325f3e318.diff

LOG: Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables

When building clang in stage2, when -DCMAKE_BUILD_TYPE=RelWithDebInfo is set,
the developer can expect that the stage2 clang is built using the same mode.
Especially as the performances are much worst in debug mode.
(Principle of least astonishment)

Differential Revision: https://reviews.llvm.org/D53014

Added: 
    

Modified: 
    clang/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/clang/CMakeLists.txt b/clang/CMakeLists.txt
index 29ceef8a4bd38..6e18e74c6294c 100644
--- a/clang/CMakeLists.txt
+++ b/clang/CMakeLists.txt
@@ -706,6 +706,7 @@ if (CLANG_ENABLE_BOOTSTRAP)
     CMAKE_CXX_COMPILER_LAUNCHER
     CMAKE_MAKE_PROGRAM
     CMAKE_OSX_ARCHITECTURES
+    CMAKE_BUILD_TYPE
     LLVM_ENABLE_PROJECTS
     LLVM_ENABLE_RUNTIMES)
 


        


More information about the cfe-commits mailing list