[PATCH] D110051: [clangd] Deduplicate inlay hints

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!

> I don't think we're likely to get a parameter hint and a type hint at the same location, but if you're concerned, I could revise the patch to ignore the hint kind during the comparison.

That's hard call to make, there are probably good arguments for:

- keeping them all
- keeping only one
- dropping them all.

I was just worried about breaking clients. We should probably account for this in the spec, as by probably forbidding any intersecting hints completely for a better UX (as discussed with @sammccall offline).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110051/new/

https://reviews.llvm.org/D110051