[PATCH] D109967: Simplify handling of builtin with inline redefinition

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 20 17:37:54 PDT 2021


nickdesaulniers added inline comments.


================
Comment at: clang/test/CodeGen/memcpy-inline-builtin.c:1
+// RUN: %clang_cc1 -triple x86_64-unknown-unknown -S -emit-llvm -o - %s -disable-llvm-passes | FileCheck %s
+//
----------------
nickdesaulniers wrote:
> Would `-emit-codegen-only` be more appropriate here than `-disable-llvm-passes`?
No; but I don't think we need `-disable-llvm-passes` since we haven't explicitly enabled additional optimization modes via `-O` flags? ie. I suspect if we drop `-disable-llvm-passes` then nothing changes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109967/new/

https://reviews.llvm.org/D109967



More information about the cfe-commits mailing list