[PATCH] D109557: Adds a BreakBeforeClosingParen option

Mon Sep 20 14:26:55 PDT 2021

csmulhern marked an inline comment as done.
csmulhern added inline comments.

================
Comment at: clang/unittests/Format/FormatTest.cpp:22414
+
+  EXPECT_EQ("int a = (int)b;", format("int a = (\n"
+                                      "    int\n"
----------------
csmulhern wrote:
> MyDeveloperDay wrote:
> > can't this just be verifyFormat but with 3 arguments?
> Isn't that true of all the EXPECT_EQ cases (as long as the expected code is stable)? This is my first contribution and I'm basically cargo cutting what I see as the prevailing style (verifyFormat for the one param / two param case, EXPECT_EQ for the three param case). I can imagine that verifyFormat didn't support the three parameter case before and so the EXPECT_EQ usage is legacy code. Should I convert everything to use verifyFormat?
Cool. I've updated the code accordingly.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109557/new/

https://reviews.llvm.org/D109557