[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

Mon Sep 20 07:31:23 PDT 2021

aaronpuchert added a subscriber: tstellar.
aaronpuchert added a comment.

In D106713#3009130 <https://reviews.llvm.org/D106713#3009130>, @aaron.ballman wrote:

> In D106713#3007878 <https://reviews.llvm.org/D106713#3007878>, @aaronpuchert wrote:
>
>> @aaron.ballman, since this is reintroducing some warnings after the relaxation in D102026 <https://reviews.llvm.org/D102026>, should we bring this to Clang 13?
>
> I think that's reasonable; the alternative is that we warn in Clang 12, don't warn in Clang 13, then start warning again in Clang 14 which does not seem very user friendly.

@tstellar, could we still bring this into release/13.x? Doesn't fix a crash, but it prevents inconsistencies between our releases and I also tested it on a pretty large code base. So I'm pretty confident it doesn't regress anything.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106713/new/

https://reviews.llvm.org/D106713