[PATCH] D110037: [X86] Always check the size of SourceTy before getting the next type
Pengfei Wang via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Sep 19 08:00:47 PDT 2021
pengfei added a comment.
I'm wondering whether the test case is required or not for this patch. Reasons:
1. We have a test in llvm-test-suite can cover this and the test is just a snippet of it;
2. The test case can not reflect the direct effect of this change;
3. There're many variables in IR which may be easily affected by unrelated changes, which is annoying to others.
What do you think?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110037/new/
https://reviews.llvm.org/D110037
More information about the cfe-commits
mailing list