[PATCH] D91944: OpenMP 5.0 metadirective

Chi Chun Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 17 12:11:22 PDT 2021


cchen added inline comments.


================
Comment at: clang/include/clang/AST/StmtOpenMP.h:5412
+
+  void setIfStmt(Stmt *stmt) { IfStmt = stmt; }
+  Stmt *getIfStmt() const { return IfStmt; }
----------------
ABataev wrote:
> 1. Make it private, please
> 2. Var names must start from capital letter `stmt`->`S`
I'm going to fix it. By the way, do you know how to fix those failing Windows tests? I tried to fix it by adding `ifndef HEADER` to test files and also replace var names with regex, but those Windows tests still fail. Thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91944/new/

https://reviews.llvm.org/D91944



More information about the cfe-commits mailing list