[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 17 09:34:33 PDT 2021


arsenm added a comment.

In D109707#3004869 <https://reviews.llvm.org/D109707#3004869>, @gandhi21299 wrote:

> Internal linkage detection works great for our purposes but it causes a failure in llvm/test/CodeGen/AMDGPU/inline-calls.ll due to `@func_alias` unable to be casted into a `Function`. If we pass through that, the `@kernel3` causes the error: `scalar registers (98) exceeds limit (96) in function 'kernel3'`.

That almost sounds like using the wrong subtarget for the alias



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:694
         if (EarlyInlineAll && !EnableFunctionCalls)
-          PM.addPass(AMDGPUAlwaysInlinePass());
+          PM.addPass(AMDGPUAlwaysInlinePass(false));
       });
----------------
This needs a backend test


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109707/new/

https://reviews.llvm.org/D109707



More information about the cfe-commits mailing list