[PATCH] D109975: [CMake] Consistently use the LibXml2::LibXml2 target instead of LIBXML2_LIBRARIES

[Arthur O'Dwyer via Phabricator via cfe-commits]

Quuxplusone added a comment.
Herald added a subscriber: JDevlieghere.

Serendipitously, I just yesterday upgraded from OSX 10.14 to 10.15, and have been unable to build clang because, even with a totally-empty-and-brand-new build directory, CMake says:

  CMake Error in lib/WindowsManifest/CMakeLists.txt:
    Imported target "LibXml2::LibXml2" includes non-existent path
      "/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/libxml2"
    in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:
    * The path was deleted, renamed, or moved to another location.
    * An install or uninstall procedure did not complete successfully.
    * The installation package was faulty and references files it does not
    provide.
  -- Generating done
  CMake Generate step failed.  Build files cannot be regenerated correctly.

Do you think this PR would fix that issue on OSX 10.15?
(IMHO it's also weird that OSX would even be trying to build anything with `Windows` in the name.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109975/new/

https://reviews.llvm.org/D109975