[PATCH] D109609: [C++4OpenCL] Add support for multiple address spaced destructors

Ole Strohm via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 17 07:43:44 PDT 2021


olestrohm updated this revision to Diff 373218.
olestrohm added a comment.

I made the implicit destructor always be created in __generic address space.

I couldn't manage to properly figure a case that would trigger `LookupSpecialMember`,
so I couldn't figure out how or if address spaces are handled there.

re: @keryell 
This might work, though I have no idea how that `SomeAPIReturningAddrSpace` would work, since at this point the variable would likely be cast to be in __generic addrspace.
Also I'm not sure how that would interact with deleted destructors.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109609/new/

https://reviews.llvm.org/D109609

Files:
  clang/include/clang/AST/DeclCXX.h
  clang/include/clang/Sema/Sema.h
  clang/lib/AST/DeclCXX.cpp
  clang/lib/Sema/SemaDeclCXX.cpp
  clang/lib/Sema/SemaLookup.cpp
  clang/test/SemaOpenCLCXX/addrspace-destructors.clcpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109609.373218.patch
Type: text/x-patch
Size: 10219 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210917/725dc582/attachment.bin>


More information about the cfe-commits mailing list