[PATCH] D109951: [clang-format] Constructor initializer lists format with pp directives

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 17 04:47:13 PDT 2021


MyDeveloperDay added inline comments.


================
Comment at: clang/unittests/Format/FormatTest.cpp:19299
+               ", d{d} {\n}",
+               Style);
+}
----------------
MyDeveloperDay wrote:
> I think its good to add what you expect without the CONDITION too!
Can you add doubly nested test

```
SomeClass::Constructor()
    : x {
  x
}
#if WINDOWS
#if DEBUG
, y { 0 }
#else
, y { 1 }
#endif
#else
#if DEBUG
, y { 2 }
#else
, y { 3 }
#endif
#endif
{}
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109951/new/

https://reviews.llvm.org/D109951



More information about the cfe-commits mailing list