[PATCH] D108832: [Builtins] Support ext_vector_type args for __builtin_fminf.

Florian Hahn via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 17 02:03:53 PDT 2021


fhahn planned changes to this revision.
fhahn added a comment.

In D108832#2969538 <https://reviews.llvm.org/D108832#2969538>, @erichkeane wrote:

> Codewise I'm ok, but I don't feel comfortable making the direction decision.  I'd like to see some level of 'state of things' on the vector types (like, under what conditions does GCC support this, and under what types??), but even then I'm not sure I'm the right one to approve this.

Thanks! I'm preparing a proposal for cfe-dev at the moment. In addition to supporting element wise min/max/round & co I think we should also make sure the proposal also allows adding reduction versions in a consistent manner. I don't think that would be possible when overloading the existing builtins, so I am exploring a different direction at the moment.

Marking as changes planned for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108832/new/

https://reviews.llvm.org/D108832



More information about the cfe-commits mailing list