[PATCH] D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A

[Sjoerd Meijer via Phabricator via cfe-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Thanks, looks reasonable to me.



================
Comment at: llvm/unittests/Support/TargetParserTest.cpp:495
                           ARMBuildAttrs::CPUArch::v8_A));
+  EXPECT_TRUE(
+      testARMArch("armv9-a", "generic", "v9a",
----------------
vhscampos wrote:
> SjoerdMeijer wrote:
> > I haven't looked, but in these target parser tests, do we also not need to check the architecture descriptions?
> > Copied this for example from the target parser def file:
> > 
> >          (ARM::AEK_SEC | ARM::AEK_MP | ARM::AEK_VIRT | ARM::AEK_HWDIVARM |
> >           ARM::AEK_HWDIVTHUMB | ARM::AEK_DSP | ARM::AEK_CRC | ARM::AEK_RAS |
> >           ARM::AEK_DOTPROD)
> If I understand it correctly, we only check architecture extensions for CPUs, not for the architectures themselves.
Ah yeah, I confused it with that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109517/new/

https://reviews.llvm.org/D109517