[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation
Teresa Johnson via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Sep 16 16:26:18 PDT 2021
tejohnson added a comment.
Ok thanks. I need to go through the propagation code and tests again more closely now, but one question/suggestion below in the meantime.
================
Comment at: llvm/include/llvm/IR/ModuleSummaryIndex.h:580
+ // If there are calls to unknown targets (e.g. indirect)
+ unsigned hasUnknownCall : 1;
+
----------------
Now that we have MayThrow, can we avoid a separate hasUnknownCall bool and just conservatively set MayThrow true in that case?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D36850/new/
https://reviews.llvm.org/D36850
More information about the cfe-commits
mailing list