[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

[Nathan Sidwell via Phabricator via cfe-commits]

urnathan added inline comments.


================
Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:3198-3199
     // lookups will find it.
     MergeDC->makeDeclVisibleInContextImpl(New, /*Internal*/true);
+    if (isa<NamespaceDecl>(New) && Name.getAsString() == "std")
+      if (!Reader.getSema()->StdNamespace)
----------------
Don't we also have to check New's context is the global namespace?  What happens for something like 'namespace evil::std {};'?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58920/new/

https://reviews.llvm.org/D58920