[PATCH] D109854: Support Unicode 14 identifiers

Thu Sep 16 05:30:19 PDT 2021

aaron.ballman added a comment.

Thanks for this! Can you add a test case that shows we now accept some Unicode 14 characters that Clang previously would have rejected (with a comment explaining what's being tested)?

================
Comment at: clang/lib/Lex/UnicodeCharSets.h:13

 // Unicode 13 XID_Start
 static const llvm::sys::UnicodeCharRange XIDStartRanges[] = {
----------------
Looks like this comment needs to be updated.

================
Comment at: clang/lib/Lex/UnicodeCharSets.h:235

 // Unicode 13 XID_Continue, excluding XID_Start
 // The Unicode Property XID_Continue is a super set of XID_Start.
----------------
This comment needs updating as well.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109854/new/

https://reviews.llvm.org/D109854