[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.
Hongtao Yu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 14 18:44:11 PDT 2021
hoy added inline comments.
================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:772
+void PerfReaderBase::emitAccumulatedWarnings() {
+ for (auto Address : InvalidReturnAddresses) {
----------------
wenlei wrote:
> nit: emitAccumulatedWarnings -> warnTruncatedStack
Makes sense. I was making this cover all warnings for future use. But sounds good to stick with truncated stack for now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109638/new/
https://reviews.llvm.org/D109638
More information about the cfe-commits
mailing list