[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

Tue Sep 14 14:26:31 PDT 2021

daltenty added inline comments.

================
Comment at: clang/test/Driver/aix-toolchain-include.cpp:31
+// CHECK-INTERNAL-INCLUDE:      "-isysroot" "[[SYSROOT:[^"]+]]"
+// CHECK-INTERNAL-INCLUDE-CXX:  "-internal-isystem" "[[SYSROOT]]/opt/IBM/openxlCSDK/include/c++/v1"
+// CHECK-INTERNAL-INCLUDE-CXX:  "-D__LIBC_NO_CPP_MATH_OVERLOADS__"
----------------
ZarkoCA wrote:
> It looks like this test is failing the pre-merge check on the x86 bot because this variable isn't captured correctly.
> From what I can see, I think you can fix this by capturing it in the RUN line instead. 
> 
> Eg. I found this `test/Driver/darwin-header-search-libcxx.cpp` and https://llvm.org/docs/CommandGuide/FileCheck.html#cmdoption-filecheck-d-var.
> 
Hmm, it seems it's not so much that the capture isn't working, but likely that we don't expect windows directory separators in the match. Regardless, I'll update the test.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109078/new/

https://reviews.llvm.org/D109078