[PATCH] D109632: [clang] de-duplicate methods from AST files

[Volodymyr Sapsai via Phabricator via cfe-commits]

vsapsai added a comment.

I'm a little bit confused here. Where is the speed-up coming from? Is it because ObjCMethodList for `init` not being serialized? I'm asking because right now I don't see how `seen` helps with that.

My current understanding is that `Sema::addMethodToGlobalList` is too expensive and `seen` reduces the number of calls to it. So maybe it makes sense to invest into making it faster? For example, `Sema::MatchTwoMethodDeclarations` can return early if both method decl pointers are equal. But I haven't done any measurements, that's just an example.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109632/new/

https://reviews.llvm.org/D109632