[PATCH] D109718: [HIP] Diagnose -fopenmp-targets for HIP programs

[Artem Belevich via Phabricator via cfe-commits]

tra added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:704
+            C.getInputArgs().getLastArg(options::OPT_fopenmp_targets_EQ)) {
+      Diag(clang::diag::err_drv_unsupported_opt) << OMPTargetArg->getSpelling();
+      return;
----------------
yaxunl wrote:
> tra wrote:
> > I think "unsupported" here is a bit misleading. We need something along the lines of "option X can't be used with option Y".
> > 
> > I think `err_drv_argument_not_allowed_with` might be a better choice.
> That is for two conflicting options. However, HIP may be specified by input file extension instead of -x option. Another issue is that this is unsupported option for HIP, not option argument.
> 
> How about
> 
> unsupported option '%1' for HIP language mode
SGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109718/new/

https://reviews.llvm.org/D109718