[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 14 07:31:32 PDT 2021


aaron.ballman added a comment.

In D108893#2999681 <https://reviews.llvm.org/D108893#2999681>, @Eugene.Zelenko wrote:

> In D108893#2999654 <https://reviews.llvm.org/D108893#2999654>, @aaron.ballman wrote:
>
>> In D108893#2999645 <https://reviews.llvm.org/D108893#2999645>, @Eugene.Zelenko wrote:
>>
>>> What about adding `modernize`/`bugprone` aliases?
>>
>> I'd be fine if we wanted to add aliases, but I'd sort of expect some extra functionality out of a check in those modules. I think it's fine to land this now, and we can add aliases in a follow-up. WDYT?
>
> Aliases code is trivial comparing with check itself, so it make sense to add it in this patch.

So you'd like to see that extra functionality added now? (I don't think it makes sense to have the check as-is in both `readability` and `modernize`.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108893/new/

https://reviews.llvm.org/D108893



More information about the cfe-commits mailing list