[PATCH] D108823: [PowerPC] Mark splat immediate instructions as rematerializable

Amy Kwan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 13 16:15:00 PDT 2021


amyk added a comment.

A question I have is, I noticed there are some test case changes involving `xxspltidp` and `xxsplti32dx`, but are additional tests needed for `xxspltiw`?



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:1887
 
 // XXSPLI32DX needs extra flags to make sure the compiler does not attempt
 // to spill part of the instruction when the values are similar.
----------------
nit: Update this comment to include `xxspltiw` and `xxspltidp`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108823/new/

https://reviews.llvm.org/D108823



More information about the cfe-commits mailing list