[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative
Philippe Antoine via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Sep 13 11:33:53 PDT 2021
catenacyber added a comment.
Thanks for the quick reply
> I don't think this change is responsible. This has been tested by many C++ downstream groups.
What did I do wrong ?
Adding this only commit makes the scenario fail.
> Rust should use upgrade its lib/ProfileData and compiler-rt/lib/profile, and not mix raw profile files at different commits.
I am not sure I understand.
What are raw profiles ?
In my scenario, only `llvm-profdata` acts on default.profraw
And before that, the linker, not the rust compiler, mixes together the different coverage sections...
So, how would Rust mix raw profiles ?
> The binary ID change has caused a bit of churn to ProfileData but it is unrelated to this patch.
Well, there may be other bugs, but this is not a problem in my scenario...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104556/new/
https://reviews.llvm.org/D104556
More information about the cfe-commits
mailing list