[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 13 10:34:16 PDT 2021


aaron.ballman added a comment.

In D69764#2997910 <https://reviews.llvm.org/D69764#2997910>, @MyDeveloperDay wrote:

> I think the relevance of Left/Right  East/West as a setting is less important, as its more about an ordering, allowing some tokens to go to the Left and some to the Right of the "type"
>
>   QualifierAlignment: Custom
>   QualifierOrder: [ inline, static, type, const, volatile, restrict ]
>
> While I currently include the Left/Right for some form of completeness I sort of feel i should kill them before we landing this, as I think even my defaults are a little subjective. (unless we can get concencus), hence I don't feel the need to bring back up the Left/Right/East/West debate. If its still a problem later we can add them.

+1, I think this style of configuration is easier to reason about than left/right, east/west, before/after, etc because it's an explicit ordering.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69764/new/

https://reviews.llvm.org/D69764



More information about the cfe-commits mailing list