[PATCH] D109694: Driver: Add preferred gcc triples for Red Hat operating systems
Fangrui Song via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Sep 13 09:22:39 PDT 2021
MaskRay added a comment.
Haven't looked closely at this particular commit, but I think hard coding the detected triples is almost always a bad idea.
See https://reviews.llvm.org/D63497#2993662 for a longer comment.
The proper way is (1) making sure CMake `LLVM_DEFAULT_TARGET_TRIPLE` is correct at configure time (2) the user should specify the complete --target=.
Inferring random target triple from an incomplete `--target=x86_64` really should not be supported.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109694/new/
https://reviews.llvm.org/D109694
More information about the cfe-commits
mailing list