[PATCH] D109128: [VFS] Use original path when falling back to external FS
Jonas Devlieghere via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Sep 13 08:28:07 PDT 2021
JDevlieghere added a comment.
Keith and I discussed this offline. My suggestion was to do the following:
1. Check the overlay for the canonicalized path
2. Check the fall-through for the canonicalized path
3. Check the fall-through for the original path
If I understand correctly, this patch does that, but swaps 2 and 3. What's the motivation for trying the non-canonical path first? If we treat the current working directory as a property directory (which is what the canonicalization is all about), then it seems like we should exhaust those options first.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109128/new/
https://reviews.llvm.org/D109128
More information about the cfe-commits
mailing list