[PATCH] D109632: [clang] de-duplicate methods from AST files

[Manman Ren via Phabricator via cfe-commits]

manmanren added a comment.

This looks good to me in general. Since it should not change functionality, it may not be possible to write a test case.

Manman



================
Comment at: clang/lib/Serialization/ASTReader.cpp:8194
+    if (seen.insert(M).second) {
+      S.addMethodToGlobalList(&List, M);
+    }
----------------
Does it make sense to check for duplication inside addMethodToGlobalList, as the function goes through the list as well? Maybe it is slower, as we will need to go through the list for each method, instead of a lookup.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109632/new/

https://reviews.llvm.org/D109632