[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

Fri Sep 10 03:49:39 PDT 2021

dyung added a comment.

In D106809#2994067 <https://reviews.llvm.org/D106809#2994067>, @saiislam wrote:

> In D106809#2993666 <https://reviews.llvm.org/D106809#2993666>, @kwk wrote:
>
>> @saiislam please have a look into why this happens. Is the `-debug-only=CodeObjectCompatibility` maybe a left-over of some sort?
>
> No, it is not a left-over. I was using this debug output to show that new and old bundle entry ID formats are compatible with each other.
>
> I am taking a look on how to fix this. Thanks for pointing it out @RKSimon and @kwk .

We are also seeing this issue on our internal build bot that builds a "release" configuration.

If you must use "-debug-only" in your test, a fix could be to add "REQUIRES: asserts" to the test, but that would mean the test would then be completely skipped in release builds. A better solution might be to break out the run line with "-debug-only" to a separate test file which does have a "REQUIRES: asserts" line so that we still run everything else that we can.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106809/new/

https://reviews.llvm.org/D106809