[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

[Konrad Wilhelm Kleine via Phabricator via cfe-commits]

kwk added a comment.

@saiislam please have a look into why this happens. Is the `-debug-only=CodeObjectCompatibility` maybe a left-over of some sort?



================
Comment at: clang/test/Driver/clang-offload-bundler.c:405
+// Tests to check compatibility between Bundle Entry ID formats i.e. between presence/absence of extra hyphen in case of missing environment field
+// RUN: clang-offload-bundler -unbundle -type=a -targets=openmp-amdgcn-amd-amdhsa--gfx906,openmp-amdgcn-amd-amdhsa-gfx908 -inputs=%t.input-archive.a -outputs=%t-archive-gfx906-simple.a,%t-archive-gfx908-simple.a -debug-only=CodeObjectCompatibility 2>&1 | FileCheck %s -check-prefix=BUNDLECOMPATIBILITY
+// BUNDLECOMPATIBILITY: Compatible: Exact match:        [CodeObject: openmp-amdgcn-amd-amdhsa-gfx906]   :       [Target: openmp-amdgcn-amd-amdhsa--gfx906]
----------------
RKSimon wrote:
> @saiislam This is causing an issue on a thinlto buildbot: https://lab.llvm.org/buildbot/#/builders/67/builds/4148
@saiislam We're seeing the same issue in one of our [downstream builders](https://download.copr.fedorainfracloud.org/results/kkleine/llvm-snapshots/fedora-rawhide-x86_64/02687097-clang/builder-live.log.gz): 

```
: 'RUN: at line 405';   clang-offload-bundler -unbundle -type=a -targets=openmp-amdgcn-amd-amdhsa--gfx906,openmp-amdgcn-amd-amdhsa-gfx908 -inputs=/builddir/build/BUILD/clang-14.0.0.src/redhat-linux-build/test/Driver/Output/clang-offload-bundler.c.tmp.input-archive.a -outputs=/builddir/build/BUILD/clang-14.0.0.src/redhat-linux-build/test/Driver/Output/clang-offload-bundler.c.tmp-archive-gfx906-simple.a,/builddir/build/BUILD/clang-14.0.0.src/redhat-linux-build/test/Driver/Output/clang-offload-bundler.c.tmp-archive-gfx908-simple.a -debug-only=CodeObjectCompatibility 2>&1 | /usr/bin/FileCheck /builddir/build/BUILD/clang-14.0.0.src/test/Driver/clang-offload-bundler.c -check-prefix=BUNDLECOMPATIBILITY
--
Exit Code: 1

Command Output (stderr):
--
/builddir/build/BUILD/clang-14.0.0.src/test/Driver/clang-offload-bundler.c:406:25: error: BUNDLECOMPATIBILITY: expected string not found in input
// BUNDLECOMPATIBILITY: Compatible: Exact match: [CodeObject: openmp-amdgcn-amd-amdhsa-gfx906] : [Target: openmp-amdgcn-amd-amdhsa--gfx906]
                        ^
<stdin>:1:1: note: scanning from here
clang-offload-bundler: Unknown command line argument '-debug-only=CodeObjectCompatibility'. Try: 'clang-offload-bundler --help'
^

Input file: <stdin>
Check file: /builddir/build/BUILD/clang-14.0.0.src/test/Driver/clang-offload-bundler.c

-dump-input=help explains the following input dump.

Input was:
<<<<<<
           1: clang-offload-bundler: Unknown command line argument '-debug-only=CodeObjectCompatibility'. Try: 'clang-offload-bundler --help' 
check:406     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
           2: clang-offload-bundler: Did you mean '--unbundle=CodeObjectCompatibility'? 
check:406     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>>>>

--
```




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106809/new/

https://reviews.llvm.org/D106809