[PATCH] D109498: [clang][deps] Stop using `ClangTool` for virtual files

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 9 08:39:49 PDT 2021


dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.

LGTM, with one nit.



================
Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningWorker.h:98
+  /// The in-memory filesystem laid on top the physical filesystem in `RealFS`.
+  llvm::IntrusiveRefCntPtr<llvm::vfs::InMemoryFileSystem> MemoryFS;
   /// The file system that is used by each worker when scanning for
----------------
Nit: I suggest "InMemoryFS", which sounds a bit more clear to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109498/new/

https://reviews.llvm.org/D109498



More information about the cfe-commits mailing list