[PATCH] D108560: [clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines

Salman Javed via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 8 04:37:06 PDT 2021


salman-javed-nz updated this revision to Diff 371308.
salman-javed-nz added a comment.

clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend.cpp:

- Added test to check what happens when NOLINTEND marker is used before NOLINTBEGIN marker (class B1 <https://reviews.llvm.org/B1>, line 7).
  - Warning is still displayed (NOLINTEND ends suppression but this is redundant as there was no suppression in the first place).

- Added test to check what happens when NOLINTBEGIN marker is used but no NOLINTEND marker is used afterwards (classes H1 <https://reviews.llvm.org/H1>, H2 <https://reviews.llvm.org/H2>; lines 87, 88).
  - Warning is suppressed for the remainder of the file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108560/new/

https://reviews.llvm.org/D108560

Files:
  clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
  clang-tools-extra/docs/ReleaseNotes.rst
  clang-tools-extra/docs/clang-tidy/index.rst
  clang-tools-extra/test/clang-tidy/infrastructure/Inputs/nolintbeginend/error_in_include.inc
  clang-tools-extra/test/clang-tidy/infrastructure/Inputs/nolintbeginend/nolint_in_include.inc
  clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108560.371308.patch
Type: text/x-patch
Size: 8143 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210908/a8049fcb/attachment.bin>


More information about the cfe-commits mailing list