[PATCH] D109386: Fix use-after-free from GlobalCtors associated data

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

I agree with Reid.  IRGen should never be holding naked references (across different invocations as an `ASTConsumer`) to a replaceable entity.  There are some entities that are known not to be replaceable, but in general the associated data of a global constructor doesn't seem like one of them.  We should be using a value handle for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109386/new/

https://reviews.llvm.org/D109386