[PATCH] D109175: [openmp] Emit deferred diag only when device compilation presents

Tue Sep 7 08:58:51 PDT 2021

jdoerfert added a comment.

In D109175#2986782 <https://reviews.llvm.org/D109175#2986782>, @yaxunl wrote:

> I agree with Johannes and Alexey that deferred diags are only needed when LangOpts.OMPTargetTriples.empty(). However, I am not sure whether it is only needed in device compilation.
>
> For other offloading languages like CUDA/HIP it is needed in both device and host compilation.

Technically, we might even want to delay in host only mode for OpenMP, but that is something we can revisit (e.g., by dynamically setting a flag based on the directives we've seen).
@yaxunl Should we for now check if there is any associated offload job?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109175/new/

https://reviews.llvm.org/D109175