[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver
David Tenty via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 7 07:49:37 PDT 2021
daltenty added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:240-242
+ case ToolChain::CST_Libstdcxx:
+ llvm::report_fatal_error(
+ "picking up libstdc++ headers is unimplemented on AIX");
----------------
ZarkoCA wrote:
> nit: it would be my preference to have the error case first but I also that `AIX::AddCXXStdlibLibArgs` is set up the same way so keeping them consistent may be more important.
Flipping the cases in both places for consistency should be fairly straight forward, so I think that's ok.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109078/new/
https://reviews.llvm.org/D109078
More information about the cfe-commits
mailing list