[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl added inline comments.


================
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:148
+    // Check if the last option before any colon is a triple field or a GPU name
+    if (TripleOrGPU.second.startswith("gfx") ||
+        TripleOrGPU.second.startswith("sm_")) {
----------------
This is rather fragile to determine whether a bundle ID contains GPU arch. Is there better way?

At least for HIP offload kind, GPU arch should always be there.


================
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:1298
+             // the missing input file.
+      std::vector<llvm::NewArchiveMember> EmptyArchive;
+      EmptyArchive.clear();
----------------
need a test


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106809/new/

https://reviews.llvm.org/D106809