[PATCH] D109210: [clang-tidy] Attach fixit to warning, not note, in add_new_check.py example

Whisperity via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 6 01:48:03 PDT 2021


whisperity added a comment.

@mattbeardsley Thank you for the explanation. (I'd wager some of your observations could even be added to some developer docs that's versioned in the repo. 😉) I'm not opposed to the changes at all. And indeed, it looks like `Note`s are really an advanced feature. I'm incredibly biased because I just recently finished the development of a checker in which I extensively use notes (in some test cases, there were like 8 or 9 notes attached to a warning, albeit all without a `FixIt` attached).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109210/new/

https://reviews.llvm.org/D109210



More information about the cfe-commits mailing list