[PATCH] D109210: [clang-tidy] Attach fixit to warning, not note, in add_new_check.py example

Matt Beardsley via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 3 15:31:44 PDT 2021


mattbeardsley added a comment.

Ah, and to your direct question:

> BTW, the test wasn't checking for the note's message at all?"

Right, the generated test file does not ever do `// CHECK-MESSAGES: :Row:Col: note: insert 'awesome'` (nor does the LIT setup here enforce that notes need to be checked - it enforces that all warning and error diagnostics must be checked, but it looks like it leaves out note diagnostics)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109210/new/

https://reviews.llvm.org/D109210



More information about the cfe-commits mailing list