[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

[Louis Dionne via Phabricator via cfe-commits]

ldionne reopened this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

Based on the commit description, I don't understand this change at all. Why do we want to tweak the name lookup just for `std::coroutine`? Yes, we do have an action item to finish coroutines in libc++ already, and I'd love to see a patch that does that, but I don't think that mandates changing Clang.

The rollout plan for coroutines should be:

1. Make sure we implement coroutines fully
2. Duplicate it all into namespace `std`
3. In two LLVM releases, remove all the coroutines stuff in `std::experimental`.

I'm going to revert this for now on the basis that it breaks libc++ CI. Let's have a discussion about the above if you think I'm mistaken or if I'm misunderstanding what this patch does.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108696/new/

https://reviews.llvm.org/D108696