[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

Joel E. Denny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 3 12:59:54 PDT 2021


jdenny added a comment.

In D109255#2983018 <https://reviews.llvm.org/D109255#2983018>, @jsji wrote:

> In D109255#2983017 <https://reviews.llvm.org/D109255#2983017>, @jdenny wrote:
>
>> This test is meant to check that the driver processes these options correctly.  -cc1 isn't the driver and often ignores either the positive or negative version of an option.
>
> OK, I can revert to driver + fsyntax-only if that is preferred?

That would be my preference.  Otherwise, we never test the interface exposed to the user, and the test is misnamed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109255/new/

https://reviews.llvm.org/D109255



More information about the cfe-commits mailing list