[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

David Goldman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 3 09:41:54 PDT 2021


dgoldman added a comment.

In D108556#2981712 <https://reviews.llvm.org/D108556#2981712>, @kadircet wrote:

> Hmm, it sounds like you want them to be treated one way during semantic highlighting and another during other features, which is fine but somewhat confusing. (e.g. we want to surface hover/goto on these identifiers, but we're making them less visible by encouraging editors to highlight them as keywords).

I went ahead and just ignored them in FindTarget (LMK if that's right) - I think you're right that it's unlikely to provide any real value so we might as well not support it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108556/new/

https://reviews.llvm.org/D108556



More information about the cfe-commits mailing list