[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

[Teresa Johnson via Phabricator via cfe-commits]

tejohnson added inline comments.


================
Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:25
 
 // Checks if loop unroll is invoked by normal compile, but not thinlto compile.
 // SAMPLEPGO-LABEL: define {{(dso_local )?}}void @unroll
----------------
It seems this test is explicitly checking for loop unrolling, so I'm not sure if it will fundamentally work the same if loop unrolling is off. Do you know why the below checking that "loop unroll is invoked by normal compile, but not thinlto compile" is not failing due to your target's change?

I wonder if this test should be converted somehow to an LLVM test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109234/new/

https://reviews.llvm.org/D109234