[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

[Sylvestre Ledru via Phabricator via cfe-commits]

sylvestre.ledru added inline comments.


================
Comment at: clang/docs/ClangNvlinkWrapper.rst:1
+=====================
+Clang Nvlink Wrapper
----------------
please remove one "="
rst expects alignment



================
Comment at: clang/docs/ClangNvlinkWrapper.rst:52
+  Output file generated by nvlink by linking all cubin files.
\ No newline at end of file

----------------
please add a new line



================
Comment at: clang/docs/ReleaseNotes.rst:151
+- clang-nvlink-wrapper tool introduced to support linking of cubin files
+  archived in an archive. See `Clang Nvlink Wrapper <https://clang.llvm.org/docs/ClangNvlinkWrapper.html>`_ .
+
----------------
I think you should use rst link here. Not absolute link (ex: if I generate the doc locally)
:ref:`Clang Nvlink Wrapper`
should work



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109225/new/

https://reviews.llvm.org/D109225