[PATCH] D108972: [clangd] Omit type hints that are too long

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 3 03:27:11 PDT 2021


kadircet accepted this revision.
kadircet added a subscriber: sammccall.
kadircet added a comment.
This revision is now accepted and ready to land.

Thanks! I was having some discussions with @sammccall about what we really want here. We think folding the arguments & dropping qualifiers until hint fits under the limit would be the most ideal but there's no rush. A stepping stone would be to just truncate all the template arguments (e.g. `tuple<foo<x>, foo<y>>` becomes `tuple<...>` even if `tuple<foo<...>, foo<...>>` could fit under the limit). Omitting is also fine initially, even though it's gonna feel weird (as if clangd couldn't find any hints) it is still better than extending the line to infinity!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108972/new/

https://reviews.llvm.org/D108972



More information about the cfe-commits mailing list