[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang/tools/clang-nvlink-wrapper/ClangNvlinkWrapper.cpp:63
+  ErrorOr<std::unique_ptr<MemoryBuffer>> BufOrErr =
+      MemoryBuffer::getFileOrSTDIN(Filename, -1, false);
+  if (std::error_code EC = BufOrErr.getError())
----------------
The `-1` is odd here -- this argument is a Boolean for whether the buffer is text or not, and this introduced a new MSVC warning (`'argument': truncation from 'int' to 'bool'`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108291/new/

https://reviews.llvm.org/D108291