[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

Thu Sep 2 14:00:42 PDT 2021

weiwang added a comment.

In D109175#2980900 <https://reviews.llvm.org/D109175#2980900>, @jdoerfert wrote:

> In D109175#2980806 <https://reviews.llvm.org/D109175#2980806>, @weiwang wrote:
>
>> In D109175#2980744 <https://reviews.llvm.org/D109175#2980744>, @jdoerfert wrote:
>>
>>> Why do we need this flag, is the absence of -fopenmp-targets not sufficient?
>>
>> Just double checked, this is the full omp related options currently in use:
>>
>>   "-fopenmp"
>>   "-fopenmp-version=31"
>>   "-fopenmp-version=31"
>>   "-fopenmp-cuda-parallel-target-regions"
>>
>> We saw a huge number of `DECLS_TO_CHECK_FOR_DEFERRED_DIAGS` records. I don't know if this has anything to do with omp version being 31, since prior 5.0, everything is available on host.
>
> I don't think we are selective right now. As I was saying, disable deferred parsing if fopenmp-targets is missing, no need for this option.

Sure I can certainly make the change. To make sure I understand you correctly: if -fopenmp-targets (or maybe fopenmp-is-device too) is not given from cmdline, we can just skip the deferred diags like this option does?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109175/new/

https://reviews.llvm.org/D109175