[PATCH] D109167: Try to unbreak Win build differently after 973519826edb76

Thu Sep 2 12:09:29 PDT 2021

thakis added a comment.

In D109167#2980560 <https://reviews.llvm.org/D109167#2980560>, @GMNGeoffrey wrote:

> I'm seeing a build failure coming out of this:
>
>> llvm-project/lld/wasm/Writer.cpp:521:16: error: non-const lvalue reference to type 'llvm::StringRef' cannot bind to a temporary of type 'llvm::StringRef'
>>
>>   for (auto &feature : used.keys()) {
>
> Looks like pre-merge checks failed with the same error: https://buildkite.com/llvm-project/premerge-checks/builds/54930#07373971-3d37-49cf-9def-22c0d724ee23

I had fixed this in https://github.com/llvm/llvm-project/commit/9d227543890e721b95303430ee1427ce5aa7292f . Precommit bot on this change was green though as far as I can tell.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109167/new/

https://reviews.llvm.org/D109167